Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic library prevents code signing from working in Xcode Cloud #8

Closed
joulupukki opened this issue Nov 2, 2021 · 2 comments
Closed

Dynamic library prevents code signing from working in Xcode Cloud #8

joulupukki opened this issue Nov 2, 2021 · 2 comments

Comments

@joulupukki
Copy link
Contributor

@joulupukki joulupukki commented Nov 2, 2021

In Package.swift this line forces you to choose either "Embed and Sign" or not to code sign when including ConfettiSwiftUI into an app (in Xcode):

type: .dynamic

This line isn't really needed.

I discovered this when attempting to build one of my apps with Xcode Cloud. Here's the error you get during the archive process:

ITMS-90334: Invalid Code Signature Identifier. The identifier "ConfettiSwiftUI-55554944d4fbc3d9c42f38d3b8bfbbc8cd81fa38" in your code signature for "ConfettiSwiftUI" must match its Bundle Identifier "ConfettiSwiftUI"
@simibac
Copy link
Owner

@simibac simibac commented Nov 4, 2021

Thanks for the PR -> new release 0.3.0. Please close if it is resolved.

@joulupukki
Copy link
Contributor Author

@joulupukki joulupukki commented Nov 5, 2021

Awesome. Thanks for getting this in. My app now builds perfectly with Xcode Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants