-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API - fast
#11
Comments
I don't think it makes sense to only separate out fast days without also making a separate method for non fast day holidays. I'll need to think of a name that would work as holiday is already taken. Maybe festival or chag. |
Agreed. I didn't want to touch the current |
I'm just curious, in your use case would you want Yom Kippur returned under fast days? |
It's tricky indeed, but I think Yom Kippur should be a holiday. |
That was my thinking too. |
Implemented in v1.2.0. |
I want to automatically congrats on holiday, but the blessing is different between fast and actual holiday.
We can do it without inflecting the current
holiday
API that still will return fast alongside holiday.The text was updated successfully, but these errors were encountered: