Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API - fast #11

Closed
aviadlevy opened this issue Sep 15, 2020 · 6 comments
Closed

New API - fast #11

aviadlevy opened this issue Sep 15, 2020 · 6 comments

Comments

@aviadlevy
Copy link

aviadlevy commented Sep 15, 2020

I want to automatically congrats on holiday, but the blessing is different between fast and actual holiday.

We can do it without inflecting the current holiday API that still will return fast alongside holiday.

@aviadlevy aviadlevy changed the title New API - is_fast New API - fast Sep 15, 2020
@simlist
Copy link
Owner

simlist commented Sep 23, 2020

I don't think it makes sense to only separate out fast days without also making a separate method for non fast day holidays. I'll need to think of a name that would work as holiday is already taken. Maybe festival or chag.

@aviadlevy
Copy link
Author

Agreed. I didn't want to touch the current holiday method from obvious reasons.
When you think of something, let me know and I'll update my PR

@simlist
Copy link
Owner

simlist commented Oct 22, 2020

I'm just curious, in your use case would you want Yom Kippur returned under fast days?

@aviadlevy
Copy link
Author

It's tricky indeed, but I think Yom Kippur should be a holiday.
(even the blessing for Yom Kippur is חג שמח)

@simlist
Copy link
Owner

simlist commented Oct 23, 2020

That was my thinking too.

@simlist
Copy link
Owner

simlist commented Oct 28, 2020

Implemented in v1.2.0.

@simlist simlist closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants