Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .toString() instead of casting to String in StringType #70

Merged
merged 2 commits into from Jul 9, 2019

Conversation

@knaeckeKami
Copy link
Contributor

commented Jul 9, 2019

This solves the problem of columns with mixed types as described in #69

@simolus3
Copy link
Owner

left a comment

Looks good with the nullable call, thanks for your contribution 👍

@codecov-io

This comment has been minimized.

Copy link

commented Jul 9, 2019

Codecov Report

Merging #70 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #70      +/-   ##
=========================================
+ Coverage    86.99%    87%   +<.01%     
=========================================
  Files           69     69              
  Lines         1938   1939       +1     
=========================================
+ Hits          1686   1687       +1     
  Misses         252    252
Impacted Files Coverage Δ
moor/lib/src/types/sql_types.dart 80% <100%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb9b6b...0137b34. Read the comment docs.

@simolus3 simolus3 merged commit a96da09 into simolus3:develop Jul 9, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 86.99%)
Details
codecov/project 87% (+<.01%) compared to aeb9b6b
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.