Make log group creation optional #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR: no change to policy names or permissions, just terraform restructuring to avoid deprecation warnings. recent (>v5.68.0) versions of the aws provider throw deprecation warnings for inline policies. This change moves the inline policies to separate aws_iam_role_policy resources and converts the policies from inline jsonencode to iam_policy_documents I did consider adding aws_iam_role_policies_exclusive to prevent modification of the policies from outside terraform, but that would have forced the minimum version of the provider to v5.68.0 - felt like the possible disruption didn't justify the benefit.
by default the module grants Lambda@Edge rights to create CloudWatch log groups, which can cause a proliferation of log groups across multiple regions. This change: - adds a variable to control whether the lambda function has permissions to create log groups - adds the function name as an output, to support creation of log groups outside the module - adds docs to the README explaining the rationale no change to default behaviour of the module, this should be a non-breaking change ff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.