Suggestion for possible enhancements

[Anras573]

Hi @simonech

Good to see someone else doing the ray tracer challenge with .NET CORE!

I have some suggestions if you don't mind :)

1. Instead of creating a method called add, you can define an operator called + (same for -, /, *) like this:

public static Tupple operator +(Tupple left, Tupple right)  
{  
    return new Tupple(left.X + right.X, left.Y + right.Y, left.Z + right.Z, left.W + right.W);  
}

usage:

var t1 = new Tupple(1.0f, 1.0f, 1.0f, 1.0f);
var t2 = new Tupple(2.0f, 2.0f, 2.0f, 2.0f);
var sum = t1 + t2;

2. I am not sure which version of .NET CORE you're using, but since 2.1 preview it has included a math library for float values

system.mathf

[simonech]

Hi Anders, Yeah, that was in my plans as well And didn’t know about the Mathf lib… thx for sharing Btw, tuple is with one P :)

…

-- Simone Chiaretta Microsoft MVP ASP.NET - ASPInsider Blog: http://codeclimber.net.nz RSS: http://feeds2.feedburner.com/codeclimber twitter: @simonech On 3 June 2019 at 21:10:52, Anders Bo Rasmussen (notifications@github.com) wrote: Hi @simonech <https://github.com/simonech> Good to see someone else doing the ray tracer challenge with .NET CORE! I have some suggestions if you don't mind :) 1. Instead of creating a method called add, you can define an operator called + (same for -, /, *) like this: public static Tupple operator +(Tupple left, Tupple right) { return new Tupple(left.X + right.X, left.Y + right.Y, left.Z + right.Z, left.W + right.W); } usage: var t1 = new Tupple(1.0f, 1.0f, 1.0f, 1.0f);var t2 = new Tupple(2.0f, 2.0f, 2.0f, 2.0f);var sum = t1 + t2; 1. I am not sure which version of .NET CORE you're using, but since 2.1 preview it has included a math library for float values system.mathf <https://docs.microsoft.com/en-us/dotnet/api/system.mathf?view=netstandard-2.1> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AAAPA5OSGSV7ORXKJCSZBODPYVUDXA5CNFSM4HSO22E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXLREBA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAPA5IWIHZSTRH2HIDXIKTPYVUDXANCNFSM4HSO22EQ> .

[Anras573]

Btw, tuple is with one P :)

Now I have to do a search-and-replace throughout my code!

Glad I could help :)