Bugs corrected + Suggestions #2

Merged
merged 1 commit into from Jan 28, 2012

Conversation

Projects
None yet
2 participants
Collaborator

quanturium commented Jan 28, 2012

Bugs :

  • "uploaded_at" parameters does not exist. I replaced it with "updated_at"
  • The date format was not correct.

Bug remaining :

Suggestion :

  • There is a new parameter called "thumbnail_url" (getItems). You should implement it
Bugs corrected + Suggestions
Bugs :
- "uploaded_at" parameters does not exist. I replaced it with "updated_at"
- The date format was not correct.

Bug remaining :
- The get method for getItems with "HttpParams params = new BasicHttpParams();" does not work. Here is my solution : http://cl.ly/1i1a0y040w3y0Q3V0i0x

Suggestion :
- There is a new parameter called "thumbnail_url" (getItems). You should implement it

@simong simong merged commit ce1cf8b into simong:master Jan 28, 2012

Owner

simong commented Jan 28, 2012

Thanks for the bug fixes and reports!
The getItems one was a pretty big one. I brought in commons-lang and used StringUtils instead of Tools.implode.

I've added a thumbnail getter. It might be beneficial to have something like this in the Item model
public Object get(String key) {
return json.get(key);
}

What do you think?

Again, thanks for the changes!

Collaborator

quanturium commented Jan 28, 2012

sure, why not.

Thank you for this java implementation of the CloudApp API. It's very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment