Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert ScrollPreserver hook implementation #442

Merged
merged 1 commit into from Mar 5, 2019

Conversation

@simonkberg
Copy link
Owner

commented Mar 5, 2019

This reverts the rewrite of ScrollPreserver in #236. Turns out getSnapshotBeforeUpdate actually can't be implemented in hooks yet.

@simonkberg simonkberg merged commit cb6278e into master Mar 5, 2019

4 of 6 checks passed

packtracker/css No css assets found.
Details
packtracker/javascript 599 KB — ▲ 0.07%
Details
Bucklescript Bucklescript
Details
Build Build
Details
Install Install
Details
Test Test
Details

@simonkberg simonkberg deleted the fix/scroll-preserver branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.