Fix a space leak #88

Merged
merged 1 commit into from May 17, 2016

Projects

None yet

2 participants

@ndmitchell
Contributor

Simple fix for a space leak. Reduces stack usage from 32K to < 1K.

@simonmar simonmar merged commit ca70ee0 into simonmar:master May 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@simonmar
Owner

Interesting, how are you finding these and did they actually matter?

@ndmitchell
Contributor

I'm using the techniques from http://neilmitchell.blogspot.co.uk/2015/09/detecting-space-leaks.html. I doubt any of these issues are an actual problem in practice - the code might go a bit slower and use a bit more memory, but it's unlikely to break. My main motivation is to try and convince myself these techniques work, and that they give enough feedback to enable fixing the leaks relatively quickly in an unknown code base. Happy and Alex are just nice examples of good sized projects before I ramp up to bigger things (such as GHC itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment