Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for Async to be dead before returning from cancel #42

Merged
merged 2 commits into from Jul 11, 2016

Conversation

@bitonic
Copy link
Contributor

@bitonic bitonic commented Jul 11, 2016

See #41

@simonmar
Copy link
Owner

@simonmar simonmar commented Jul 11, 2016

Would you mind rebasing and squashing these commits so we just have one change to the library and one to the test suite? That would make it a lot easier to review.

@bitonic bitonic force-pushed the children_survive branch from da503ab to cb4bedc Jul 11, 2016
@bitonic
Copy link
Contributor Author

@bitonic bitonic commented Jul 11, 2016

I've squashed the commits as suggested.

@simonmar simonmar merged commit 2eda512 into simonmar:master Jul 11, 2016
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants