Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Finish removing journalFinalise (#903)
* journal: Get rid of `journalFinalise` and use granular functions Complete the process started in 53b3e2b. This gets rid of the `journalFinalise` function and uses the smaller steps, in order to have more granular control. * journal: Change order of operations in finalization We want to make sure that we add the filepath after the order is reversed, so the added filepath is on the head and not the tail (as it would be if it were reversed after it was added). * journal: Refine granular finalization functions This commit fixes two of the granular finalization functions: 1. Rename `journalSetTime` to `journalSetLastReadTime` and improve documentation. 2. Remove `journalSetFilePath`. It's redundant with `journalAddFile` currently in `Hledger.Read.Common`. The only difference between the functions is where the file is added (we keep the one in which it is added to the tail), so we change the position vis-a-vis reversal.
- Loading branch information
1 parent
0f2a31b
commit a6a73e3
Showing
2 changed files
with
25 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters