Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support GHC 8.8 #1090

Open
simonmichael opened this issue Sep 23, 2019 · 7 comments
Open

support GHC 8.8 #1090

simonmichael opened this issue Sep 23, 2019 · 7 comments
Labels

Comments

@simonmichael
Copy link
Owner

@simonmichael simonmichael commented Sep 23, 2019

Related:

  • joelburget/easytest#26 - we need a release of easytest supporting hedgehog 1.0.1; or we need to replace easytest
  • commercialhaskell/stackage#4802 - we need a hledger release/revision supporting base-compat-batteries 0.11.0)
  • GaloisInc/json#11 - we need a json release supporting ghc 8.8, for hledger-web
    we need to replace json with aeson in hledger-web AddForm.hs
  • iconnect/regex#173 - we need a regex release supporting ghc 8.8 for Shake.hs, before making our default stack.yaml use ghc 8.8
@peti

This comment has been minimized.

Copy link
Contributor

@peti peti commented Oct 6, 2019

Stackage has switched to GHC 8.8.1 for the nightly builds and will release a new LTS version based on that compiler eventually. Is there any chance to get hledger ready for the new compiler in the foreseeable future so that it can be added to the LTS package set?

Personally, I don't see any problem supporting base-compat-batteries, but easytest has been causing trouble before and its authors don't appear to be particularly responsive either. :-(

@simonmichael

This comment has been minimized.

Copy link
Owner Author

@simonmichael simonmichael commented Oct 6, 2019

Thanks for the ping. We are ready for base-compat-batteries (in master), but easytest now feels like a backwater (we are the only user) and I think it's unlikely to revive soon. I'd be happy to get hledger migrated to a mainstream testing lib, which I think at this point is tasty.

@peti

This comment has been minimized.

Copy link
Contributor

@peti peti commented Oct 8, 2019

Personally, I'd be hugely in favor of using tasty or hspec instead of easytest. At the moment, hledger is the only package left that I can't compile with ghc-8.8.1 -- mostly due to easytest --, and it feels like it has been like this once or twice before when new GHC versions have come out.

@peti

This comment has been minimized.

Copy link
Contributor

@peti peti commented Oct 22, 2019

Is anyone actively working towards this goal?

@simonmichael

This comment has been minimized.

Copy link
Owner Author

@simonmichael simonmichael commented Oct 22, 2019

Negative

simonmichael added a commit that referenced this issue Nov 27, 2019
easytest is not actively maintained and requires an old version of
hedgehog which does not support base-compat 0.11 & ghc 8.8.

This is still using the old easytest helpers, and not displaying test
names properly.
simonmichael added a commit that referenced this issue Nov 27, 2019
Hledger.Util.Tests helpers have been cleaned up, and test names are
now shown.

Tests have been cleaned up a bit. Some groups of unnamed tests have
been collapsed into a single named test containing a sequence of
assertions. The test command counts named tests, not assertions, so
the reported unit test count has dropped from 199 to 188.
@simonmichael

This comment has been minimized.

Copy link
Owner Author

@simonmichael simonmichael commented Nov 28, 2019

I ported unit tests to tasty, and have made hledger/ui/web build with ghc 8.8. hledger-web requires an unreleased version of json, which will keep it out of stackage until released (GaloisInc/json#11). I'll leave this open for now.

simonmichael added a commit that referenced this issue Nov 28, 2019
hledger-web needs an unreleased version of json.
simonmichael added a commit that referenced this issue Nov 29, 2019
@peti

This comment has been minimized.

Copy link
Contributor

@peti peti commented Dec 4, 2019

Yay, this is very good news! I just build the entire repo with ghc-8.8.x and it worked just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.