Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support GHC 8.8 #1090

Closed
simonmichael opened this issue Sep 23, 2019 · 7 comments
Closed

support GHC 8.8 #1090

simonmichael opened this issue Sep 23, 2019 · 7 comments
Labels
A-WISH Some kind of improvement request, hare-brained proposal, or plea. packaging Dependencies, version constraints, packaging..

Comments

@simonmichael
Copy link
Owner

simonmichael commented Sep 23, 2019 •
edited

Related:
@simonmichael simonmichael added A-WISH Some kind of improvement request, hare-brained proposal, or plea. packaging Dependencies, version constraints, packaging.. labels Sep 23, 2019
@peti
Copy link
Contributor

peti commented Oct 6, 2019

Stackage has switched to GHC 8.8.1 for the nightly builds and will release a new LTS version based on that compiler eventually. Is there any chance to get hledger ready for the new compiler in the foreseeable future so that it can be added to the LTS package set?

Personally, I don't see any problem supporting base-compat-batteries, but easytest has been causing trouble before and its authors don't appear to be particularly responsive either. :-(

@simonmichael
Copy link
Owner Author

simonmichael commented Oct 6, 2019 •
edited

Thanks for the ping. We are ready for base-compat-batteries (in master), but easytest now feels like a backwater (we are the only user) and I think it's unlikely to revive soon. I'd be happy to get hledger migrated to a mainstream testing lib, which I think at this point is tasty.

@peti
Copy link
Contributor

peti commented Oct 8, 2019

Personally, I'd be hugely in favor of using tasty or hspec instead of easytest. At the moment, hledger is the only package left that I can't compile with ghc-8.8.1 -- mostly due to easytest --, and it feels like it has been like this once or twice before when new GHC versions have come out.

@peti
Copy link
Contributor

peti commented Oct 22, 2019

Is anyone actively working towards this goal?

@simonmichael
Copy link
Owner Author

Negative

simonmichael added a commit that referenced this issue Nov 27, 2019
@simonmichael
tests: port all unit tests to tasty, first cut (#1090)
13a3542 
easytest is not actively maintained and requires an old version of
hedgehog which does not support base-compat 0.11 & ghc 8.8.

This is still using the old easytest helpers, and not displaying test
names properly.
simonmichael added a commit that referenced this issue Nov 27, 2019
@simonmichael
tests: port all unit tests to tasty, second pass (#1090)
b36f6df 
Hledger.Util.Tests helpers have been cleaned up, and test names are
now shown.

Tests have been cleaned up a bit. Some groups of unnamed tests have
been collapsed into a single named test containing a sequence of
assertions. The test command counts named tests, not assertions, so
the reported unit test count has dropped from 199 to 188.
@simonmichael
Copy link
Owner Author

I ported unit tests to tasty, and have made hledger/ui/web build with ghc 8.8. hledger-web requires an unreleased version of json, which will keep it out of stackage until released (GaloisInc/json#11). I'll leave this open for now.

simonmichael added a commit that referenced this issue Nov 28, 2019
@simonmichael
cli, ui, web: support GHC 8.8, add stack-ghc8.8.yaml (#1090)
843d394 
hledger-web needs an unreleased version of json.
simonmichael added a commit that referenced this issue Nov 29, 2019
@simonmichael
;stack: use base-compat < 0.11 and latest lts for Shake/regex (#1090)
3c226f8 
[ci skip]
@peti
Copy link
Contributor

peti commented Dec 4, 2019

Yay, this is very good news! I just build the entire repo with ghc-8.8.x and it worked just fine.

simonmichael added a commit that referenced this issue Jan 5, 2020
@simonmichael
;shake: use older GHC to work around regex#173 (#1090)
412ea86 
[ci skip]
@simonmichael simonmichael mentioned this issue Jan 28, 2020
Closed
simonmichael added a commit that referenced this issue Jan 28, 2020
@simonmichael
;shake: can use the default stack.yaml/GHC 8.8 (#1090)
c84466f 
[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-WISH Some kind of improvement request, hare-brained proposal, or plea. packaging Dependencies, version constraints, packaging..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonmichael @peti