pretty-show 1.6.5 doesn't compile with GHC prior to 7.4.x #155

Closed
peti opened this Issue Jan 9, 2014 · 4 comments

Projects

None yet

2 participants

@peti
Collaborator
peti commented Jan 9, 2014

The newly addded constraint on pretty-show >=1.6.4 effectively breaks the entire hledger build on GHC 7.0.4 and 7.2.2. Was that change made intentionally?

@simonmichael
Owner

Darn. Yes, see the commit message (62b0461). Why does it break GHC 7.0 and 7.2
exactly ?

On Thu, Jan 9, 2014, at 02:11 AM, Peter Simons wrote:

The newly addded constraint on pretty-show >=1.6.4 effectively
breaks the entire hledger build on GHC 7.0.4 and 7.2.2. Was that
change made intentionally?

Reply to this email directly or [1]view it on GitHub.
[10144__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNDc5NTA3MCw
iZGF0YSI6eyJpZCI6MjMxOTc1ODN9fQ==--4c2db5e2a217a167f709edcb717b9cc8b3c7
4ba4.gif]

References

  1. #155
@peti
Collaborator
peti commented Jan 9, 2014

The error is in yav/pretty-show#9.

@simonmichael
Owner

I see a fix in pretty-show.. time to require pretty-show >= 1.6.7 ?

@peti
Collaborator
peti commented Feb 13, 2014

Unfortunately, the new version doesn't change the situation at all.

@simonmichael simonmichael added the BUG label Mar 3, 2014
@simonmichael simonmichael added a commit that closed this issue Mar 27, 2014
@simonmichael avoid pretty-show with GHC < 7.4; update tested-with (fixes #155)
hledger builds with GHC 7.2 through 7.8. 7.0 is not supported
because we require shakespeare which requires the DeriveGeneric extension.
ef1cc06
@simonmichael simonmichael added a commit that referenced this issue Apr 30, 2014
@simonmichael avoid pretty-show with GHC < 7.4; update tested-with (fixes #155)
hledger builds with GHC 7.2 through 7.8. 7.0 is not supported
because we require shakespeare which requires the DeriveGeneric extension.

(cherry picked from commit ef1cc06)
(conflict resolved manually)

Conflicts:
	hledger/hledger.cabal
28d2912
@simonmichael simonmichael added the DEPS label May 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment