hledger-web release contains files without source #161

Closed
nomeata opened this Issue Feb 9, 2014 · 6 comments

Projects

None yet

2 participants

@nomeata
Collaborator
nomeata commented Feb 9, 2014

As reported at http://bugs.debian.org/736595 the hledger-web release contains these files without their corresponding source code

static/excanvas.min.js
static/jquery.flot.js
static/jquery.js
static/jquery.url.js
static/select2.min.js

This causes problems for downstream distributions.

Could you please make a release of hledger-web that includes the corresponding source (i.e. non-minified, non-packed) files?

Bonus points for ensuring that the minified files are really derived from the source files, for example by adding a small Makefile and building them yourself, which would also serve as documentation about the tool used to create these files.

Thanks,
Joachim

@simonmichael
Owner

Thanks for the report, I have released hledger-web 0.22.2. Sorry I have not set up my own minification process, perhaps someone will contribute that, or we could just serve unminified files and assume yesod will do it for us.

@nomeata
Collaborator
nomeata commented Feb 10, 2014

Thanks for the quick fix. I was about to upload it, but it seems that hledger needs a newer version of pretty-show, which is no problem per se.... but they have added a minified jquery.js file to their distribution... so I’ll have to wait for yav/pretty-show#10 now...

@simonmichael
Owner

Ack.. well that gives me time to get it right; hledger-web is up to 0.22.4 now.

@simonmichael simonmichael added a commit that referenced this issue Apr 30, 2014
@simonmichael web: include unminified source of all javascript, to help packagers (…
…fixes #161)

(cherry picked from commit b0b9e56)
bd7fe4a
@nomeata
Collaborator
nomeata commented Jun 23, 2015

I guess this needs to be re-opened: The jquery source got lost in or before 0.24.1:
http://hdiff.luite.com/cgit/hledger-web/diff/?id=0.24.1&id2=0.23.3

You can work around the issue by using the js-jquery and js-flot packages from Hackage.

@simonmichael simonmichael reopened this Jun 23, 2015
@simonmichael
Owner

Thanks.. I think I just need to re-add the unminified jquery.js.

@simonmichael
Owner

I think this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment