1.42: `&` in CSV `if` rules broke

[gassmatt]

& in the regex expression of an if block raises error on CSV import unless the & is followed by a conditional block. Escaping with backslashes or enclosing & in a regex group expression (e.g., [ \&]*) has no effect.

Example CSV rule file

if
%description STOP \& SHOP
    account2 Expenses:Food and Supplies

Error Output

hledger: Error: ...chase-visa.rules:137:21:
    |
137 | %description STOP \& SHOP
    |                     ^
unexpected space
expecting conditional block

I'm using hledger-flow import and hledger 1.42, mac-aarch64. I did not have this error prior to 1.42.

[adept]

A very quick workaround is to replace it with "." (which you probably know, but I wanted to mention it anyway)

[gassmatt]

good point, thanks!

[simonmichael]

Sorry for breaking your rules!

I guess this is due to #2333, even though we tried to avoid breaking rules with &. @thomie would you have time to investigate ?

[simonmichael]

@gassmatt claim your https://hledger.org/REGRESSIONS.html#regression-finder-bounty when ready, the first of 1.42.

[thomie]

I will have a look tomorrow.

[thomie]

Sorry about that! The fix is easy enough, but I should have caught this earlier. Pull request in #2353.