add does not use default year/default commodity directives #26

Closed
simonmichael opened this Issue Apr 8, 2013 · 2 comments

Projects

None yet

1 participant

@simonmichael
Owner

Original author: simon@joyful.com (November 13, 2010 00:42:26)

I just implemented default commodity support, but as Eric Kow points out, this and other "journal state affecting" directives (default year, default commodity, parent account) are ignored by the add command. I guess add should use these if present, the last one encountered if there is more than one.

Original issue: http://code.google.com/p/hledger/issues/detail?id=26

@simonmichael
Owner

From simon@joyful.com on November 13, 2010 02:19:23
Here's how I think this should work:

  • add should just use the current year as default, as it does now, ignoring the journal's default year directives
  • add currently records commodity-less amounts as entered, ie with no commodity symbol. Subsequent commands will apply the default commodity to these. Instead, I think Eric is expecting it to record the amounts with an explicit commodity symbol added. I guess that is the most reasonable thing to do.
  • similarly, reporting commands will apply any parent account directives to newly-added transactions. In this case, add should not explicitly prepend the parent account(s) to the account names entered.
@simonmichael
Owner

From simon@joyful.com on November 13, 2010 15:16:57
Now implemented in darcs, along with some default account/amount fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment