New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add transaction" button not keyboard-accessible [$10] #430

Closed
ndarilek opened this Issue Nov 15, 2016 · 13 comments

Comments

Projects
None yet
6 participants
@ndarilek
Contributor

ndarilek commented Nov 15, 2016

As a keyboard user, I attempt to tab to this button but it never seems to receive focus. Also, when I do place focus on it, space/enter doesn't appear to trigger it.

Can anyone else duplicate? Granted, I've only run this within Sandstorm, but I don't imagine that would make a difference.

Thanks.


$10 bounty was claimed successfully.

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Nov 15, 2016

Owner

Hmm, you're right. The "Add a transaction" link is generated by some bootstrap or jquery modal thing, starting at https://github.com/simonmichael/hledger/blob/master/hledger-web/templates/default-layout-wrapper.hamlet#L97 . I went as far as adding tabindex=4 to all of those divs and the h3, but still couldn't tab to the link (tested in safari). Any help welcome.

There is a specific keyboard shortcut that activates the link: a (assuming the web page has the focus).

Owner

simonmichael commented Nov 15, 2016

Hmm, you're right. The "Add a transaction" link is generated by some bootstrap or jquery modal thing, starting at https://github.com/simonmichael/hledger/blob/master/hledger-web/templates/default-layout-wrapper.hamlet#L97 . I went as far as adding tabindex=4 to all of those divs and the h3, but still couldn't tab to the link (tested in safari). Any help welcome.

There is a specific keyboard shortcut that activates the link: a (assuming the web page has the focus).

@ndarilek

This comment has been minimized.

Show comment
Hide comment
@ndarilek

ndarilek Nov 15, 2016

Contributor
Contributor

ndarilek commented Nov 15, 2016

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Nov 15, 2016

Owner

The "Add a transaction" link is the h3 at line 102. I think due to the .modal-title class. I don't know why it's so complicated, it uses http://getbootstrap.com/javascript/#modals .

Owner

simonmichael commented Nov 15, 2016

The "Add a transaction" link is the h3 at line 102. I think due to the .modal-title class. I don't know why it's so complicated, it uses http://getbootstrap.com/javascript/#modals .

@simonmichael simonmichael modified the milestone: 1.1 Dec 29, 2016

@simonmichael simonmichael changed the title from "Add transaction" button not keyboard-accessible to "Add transaction" button not keyboard-accessible [$10] Dec 29, 2016

@simonmichael simonmichael added the bounty label Dec 29, 2016

@simonmichael simonmichael modified the milestone: 1.1 Dec 30, 2016

@the-solipsist

This comment has been minimized.

Show comment
Hide comment
@the-solipsist

the-solipsist Jan 15, 2017

Since the upgrade from v0.26 to v1.1, the 'a' key works for me in hledger-web. Is this still a problem?

the-solipsist commented Jan 15, 2017

Since the upgrade from v0.26 to v1.1, the 'a' key works for me in hledger-web. Is this still a problem?

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Jan 15, 2017

Owner

But the problem reported ("I attempt to tab to this button but it never seems to receive focus. Also, when I do place focus on it, space/enter doesn't appear to trigger it.") is still unsolved, right ?

Owner

simonmichael commented Jan 15, 2017

But the problem reported ("I attempt to tab to this button but it never seems to receive focus. Also, when I do place focus on it, space/enter doesn't appear to trigger it.") is still unsolved, right ?

@squiddle

This comment has been minimized.

Show comment
Hide comment
@squiddle

squiddle Mar 1, 2017

i do not know (much|any) haskell but i think the add transaction link is rendered here:

https://github.com/simonmichael/hledger/blob/master/hledger-web/Handler/JournalR.hs#L40

squiddle commented Mar 1, 2017

i do not know (much|any) haskell but i think the add transaction link is rendered here:

https://github.com/simonmichael/hledger/blob/master/hledger-web/Handler/JournalR.hs#L40

@ocdtrekkie

This comment has been minimized.

Show comment
Hide comment
@ocdtrekkie

ocdtrekkie Jun 5, 2018

Contributor

So interestingly enough: this issue should probably be closed with regards to hledger-web in general... but even though it works on demo.hledger.org, it does not work on my new Sandstorm build, and the href tag is missing there.

Contributor

ocdtrekkie commented Jun 5, 2018

So interestingly enough: this issue should probably be closed with regards to hledger-web in general... but even though it works on demo.hledger.org, it does not work on my new Sandstorm build, and the href tag is missing there.

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Jun 5, 2018

Owner

This does seem to be resolved, closing.

Owner

simonmichael commented Jun 5, 2018

This does seem to be resolved, closing.

@ocdtrekkie

This comment has been minimized.

Show comment
Hide comment
@ocdtrekkie

ocdtrekkie Jun 5, 2018

Contributor

@zarybnicky should probably claim the bounty or whatever since they fixed it like a year ago.

Contributor

ocdtrekkie commented Jun 5, 2018

@zarybnicky should probably claim the bounty or whatever since they fixed it like a year ago.

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Jun 5, 2018

Owner

Agreed, @zarybnicky please go ahead.

Owner

simonmichael commented Jun 5, 2018

Agreed, @zarybnicky please go ahead.

@zarybnicky

This comment has been minimized.

Show comment
Hide comment
@zarybnicky

zarybnicky Jun 6, 2018

Oh, I've completely forgotten about this, thanks for tagging me. I'll have a look at how to claim the bounty.

(I was about to start trying to replicate the issue on Sandstorm but apparently, according to #425, it's resolved there as well.)

zarybnicky commented Jun 6, 2018

Oh, I've completely forgotten about this, thanks for tagging me. I'll have a look at how to claim the bounty.

(I was about to start trying to replicate the issue on Sandstorm but apparently, according to #425, it's resolved there as well.)

@ocdtrekkie

This comment has been minimized.

Show comment
Hide comment
@ocdtrekkie

ocdtrekkie Jun 6, 2018

Contributor

@zarybnicky Yeah, turns out I didn't actually update the Sandstorm grain I opened to test it. :/

Contributor

ocdtrekkie commented Jun 6, 2018

@zarybnicky Yeah, turns out I didn't actually update the Sandstorm grain I opened to test it. :/

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Jun 6, 2018

Owner

Bounty was claimed successfully. Good to see that Bountysource still works.. except for updating the issue text. I'll do that manually.

Owner

simonmichael commented Jun 6, 2018

Bounty was claimed successfully. Good to see that Bountysource still works.. except for updating the issue text. I'll do that manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment