New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--date2 does not show the auxiliary date #604

Closed
benjamin-thomas opened this Issue Aug 21, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@benjamin-thomas

benjamin-thomas commented Aug 21, 2017

Version: hledger-ui 1.3


Hello,

Great job on your apps, very much enjoying exploring the different possibilities offered here...

I stumbled upon a little hiccup though. The manual states:

  --date2               show, and make -b/-e/-p/date: match, secondary
                           dates instead

However, given the following ledger file

2017/01/01 Opening Balance
    Assets:CheckingAccount                      100€
    Equity:OpeningBalance

2017/01/02=2017/01/03 Supermarket
    Expenses:Food:Groceries                      40€
    Assets:CheckingAccount

The following commands display the same dates:

hledger-ui -f ~/test.ledger
hledger-ui -f ~/test.ledger --date2

Meaninng, for the Supermarket entry, I would expect 2017/01/03 to be displayed with the --date2 flag.

Any thoughts?

@simonmichael simonmichael added the ui label Aug 21, 2017

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Aug 21, 2017

Owner

Thanks @benjamin-thomas. You're right, hledger-ui doesn't seem to pay much (any ?) attention to --date2.

General flags like this aren't required to have an effect on every single command. I know --date2 affects the output of the register command, but otherwise I think it mainly affects date matching. Perhaps the wording of its help could be improved.

As for making it affect hledger-ui - I would consider a PR, but I don't think it's needed. I consider --date2 and secondary dates to be a misfeature actually, and always recommend overriding posting dates instead.

Owner

simonmichael commented Aug 21, 2017

Thanks @benjamin-thomas. You're right, hledger-ui doesn't seem to pay much (any ?) attention to --date2.

General flags like this aren't required to have an effect on every single command. I know --date2 affects the output of the register command, but otherwise I think it mainly affects date matching. Perhaps the wording of its help could be improved.

As for making it affect hledger-ui - I would consider a PR, but I don't think it's needed. I consider --date2 and secondary dates to be a misfeature actually, and always recommend overriding posting dates instead.

@benjamin-thomas

This comment has been minimized.

Show comment
Hide comment
@benjamin-thomas

benjamin-thomas Aug 22, 2017

Thanks for the detailed feedback!

Yes the wording is a little ambiguous, but then again there are quite a lot of features.

I'd love to dig in, but being unfamiliar with Haskell, it's not very realistic for me at the moment.

Overriding post dates seems much better, thanks!

Closing this, since it was a misunderstanding on my part.

benjamin-thomas commented Aug 22, 2017

Thanks for the detailed feedback!

Yes the wording is a little ambiguous, but then again there are quite a lot of features.

I'd love to dig in, but being unfamiliar with Haskell, it's not very realistic for me at the moment.

Overriding post dates seems much better, thanks!

Closing this, since it was a misunderstanding on my part.

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Aug 22, 2017

Owner

Thanks for the report. As a minimal fix, I'm thinking

--date2               make -b/-e/-p/date: match secondary dates instead; make register show secondary date
Owner

simonmichael commented Aug 22, 2017

Thanks for the report. As a minimal fix, I'm thinking

--date2               make -b/-e/-p/date: match secondary dates instead; make register show secondary date
@benjamin-thomas

This comment has been minimized.

Show comment
Hide comment
@benjamin-thomas

benjamin-thomas Aug 22, 2017

Yeah this seems better to me!

Keep on the great work :)

benjamin-thomas commented Aug 22, 2017

Yeah this seems better to me!

Keep on the great work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment