New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hledger-web 1.4 showing zero amount accounts by default #641

Open
ohmyohmyohmy opened this Issue Nov 8, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@ohmyohmyohmy

ohmyohmyohmy commented Nov 8, 2017

hledger-web 1.4 is showing zero amount accounts by default. So, there's no option to turn it off.

Running on Windows 7.

Thanks!

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Nov 8, 2017

Owner

Hi, you're right. It was hard-coded, as part of hledger-web's goal of being a simple UI that just works without surprises for non-power-users. Is it causing you a lot of trouble ?

Owner

simonmichael commented Nov 8, 2017

Hi, you're right. It was hard-coded, as part of hledger-web's goal of being a simple UI that just works without surprises for non-power-users. Is it causing you a lot of trouble ?

@ohmyohmyohmy

This comment has been minimized.

Show comment
Hide comment
@ohmyohmyohmy

ohmyohmyohmy Nov 9, 2017

It's just not pretty having a whole bunch of Accounts Receivables (about 50) showing zero, on my balance sheet is all. I'd just like a way to turn it off.

Plus, I was expecting zero amount accounts to be hidden by default as stated in the doc:

-E --empty
show items with zero amount, normally hidden

ohmyohmyohmy commented Nov 9, 2017

It's just not pretty having a whole bunch of Accounts Receivables (about 50) showing zero, on my balance sheet is all. I'd just like a way to turn it off.

Plus, I was expecting zero amount accounts to be hidden by default as stated in the doc:

-E --empty
show items with zero amount, normally hidden

@simonmichael simonmichael added A BUG docs and removed A WISH labels Nov 11, 2017

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Nov 11, 2017

Owner

That does sound annoying. And you're right that it's at least a docs bug.

On the other hand: I imagine non-expert users starting up hledger-web, and not seeing a full picture of their assets (eg) just because some of them happen to be currently empty, and this seems like a usability/discoverability problem to me.

I'm not using hledger-web a lot at the moment, but maybe what's needed is a discoverable toggle within the UI ? Maybe somebody can work on this ?

Owner

simonmichael commented Nov 11, 2017

That does sound annoying. And you're right that it's at least a docs bug.

On the other hand: I imagine non-expert users starting up hledger-web, and not seeing a full picture of their assets (eg) just because some of them happen to be currently empty, and this seems like a usability/discoverability problem to me.

I'm not using hledger-web a lot at the moment, but maybe what's needed is a discoverable toggle within the UI ? Maybe somebody can work on this ?

@ohmyohmyohmy

This comment has been minimized.

Show comment
Hide comment
@ohmyohmyohmy

ohmyohmyohmy Nov 11, 2017

Yeah, I see what you mean. Though, I imagine anyone using hledger-web would have started with hledger or ledger-cli first, and then try hledger-web out of curiousity, so the concern with non-experts (which is who I am by the way) may be a non-issue.

Like me, I started with hledger and then tried hledger-web, so I sorta expected both to act the same way, and have zero amount accounts hidden by default and the option to turn it on with -E when I want it to. I actually thought I did something wrong, and was checking my ledger file to see if I entered something, a special comment maybe, that would turn zero-amount accounts on (told you I was a non-expert).

A simple checkbox at the top-left corner with the words "Show accounts with zero amounts" then "refresh", would help, I guess?

ohmyohmyohmy commented Nov 11, 2017

Yeah, I see what you mean. Though, I imagine anyone using hledger-web would have started with hledger or ledger-cli first, and then try hledger-web out of curiousity, so the concern with non-experts (which is who I am by the way) may be a non-issue.

Like me, I started with hledger and then tried hledger-web, so I sorta expected both to act the same way, and have zero amount accounts hidden by default and the option to turn it on with -E when I want it to. I actually thought I did something wrong, and was checking my ledger file to see if I entered something, a special comment maybe, that would turn zero-amount accounts on (told you I was a non-expert).

A simple checkbox at the top-left corner with the words "Show accounts with zero amounts" then "refresh", would help, I guess?

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Nov 11, 2017

Owner

Some possible resolutions:

A. change hledger-web --help/docs to match the current behaviour (always show zero-balance accounts)

B. change hledger-web to behave like hledger (show zero-balance accounts only if you start it with a -E command line flag. Won't be available to GUI users double-clicking the hledger-web icon.)

C. enhance hledger-web so zero-balance accounts can be toggled in the UI (as in hledger-ui), making them discoverable

My preference would be C. If nobody wants to work on that, I'd accept a PR removing the special case and enabling B, but it should be cleared with the mail list too, to see if existing users have any objection.

Owner

simonmichael commented Nov 11, 2017

Some possible resolutions:

A. change hledger-web --help/docs to match the current behaviour (always show zero-balance accounts)

B. change hledger-web to behave like hledger (show zero-balance accounts only if you start it with a -E command line flag. Won't be available to GUI users double-clicking the hledger-web icon.)

C. enhance hledger-web so zero-balance accounts can be toggled in the UI (as in hledger-ui), making them discoverable

My preference would be C. If nobody wants to work on that, I'd accept a PR removing the special case and enabling B, but it should be cleared with the mail list too, to see if existing users have any objection.

@dotlambda

This comment has been minimized.

Show comment
Hide comment
@dotlambda

dotlambda Nov 11, 2017

I think hledger-ui is doing the same: It shows zero-balance accounts that hledger balance doesn't show unless you pass the -E flag.

dotlambda commented Nov 11, 2017

I think hledger-ui is doing the same: It shows zero-balance accounts that hledger balance doesn't show unless you pass the -E flag.

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Nov 14, 2017

Owner

(There was no objection, PRs welcome.)

Owner

simonmichael commented Nov 14, 2017

(There was no objection, PRs welcome.)

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Nov 14, 2017

Owner

@dotlambda you're right, hledger-ui shows zero-balance accounts by default, with no way to change that initial setting, and incorrect command-line help for hledger-ui -E. We should change -E's help, to "hidden by some commands" or something.

hledger-ui does provide discoverable UI (the Z key) for toggling them, at least. (Note the change of letter. I found it more mnemonic - Z toggles zeroes - and E was valuable for something else. Would there be any sense in also allowing -Z on the command line ?)

Owner

simonmichael commented Nov 14, 2017

@dotlambda you're right, hledger-ui shows zero-balance accounts by default, with no way to change that initial setting, and incorrect command-line help for hledger-ui -E. We should change -E's help, to "hidden by some commands" or something.

hledger-ui does provide discoverable UI (the Z key) for toggling them, at least. (Note the change of letter. I found it more mnemonic - Z toggles zeroes - and E was valuable for something else. Would there be any sense in also allowing -Z on the command line ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment