New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual artefacts in hledger-ui after update to 1.10.1 #838

Closed
dstrelnikov opened this Issue Jul 15, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@dstrelnikov

dstrelnikov commented Jul 15, 2018

Hey there!

I have just updated hledger-ui to 1.10.1 after 1.9 with the command

stack install --resolver=nightly-2018-06-02 hledger-ui-1.10.1

and got some visual artefacts in ui:

screenshot_20180715_133840

@simonmichael

This comment has been minimized.

Owner

simonmichael commented Jul 15, 2018

Uh, that's.. weird. The body text is blurred, and the title/footer text isn't ? What happens with --theme greenterm and --theme terminal ?

@simonmichael

This comment has been minimized.

Owner

simonmichael commented Jul 15, 2018

Oh, no, surely you've just blurred the data for privacy. What is the visual artefact you mean ?

@dstrelnikov

This comment has been minimized.

dstrelnikov commented Jul 15, 2018

Oh, no, surely you've just blurred the data for privacy. What is the visual artefact you mean ?

Yes, sorrry, I have to explain this :)

I mean the top and the bottom lines. There are white spaces. They was fully black before the update. Compare with this:

screenshot_20180715_153827

What happens with --theme greenterm and --theme terminal ?

It's absolutely okay with both greenterm and terminal.

@simonmichael

This comment has been minimized.

Owner

simonmichael commented Jul 15, 2018

I see it. Thanks for the report! Here are my 1.9 and 1.10.1 builds on macos in iterm2:

screen shot 2018-07-15 at 2 04 09 pm

I don't see anything obviously related in the brick, vty or ansi-terminal changelogs; any debugging help is welcome.

@simonmichael simonmichael added A BUG and removed platform: linux labels Jul 15, 2018

@simonmichael simonmichael changed the title from Visial artefacts in hledger-ui adfter update to 1.10.1 to Visual artefacts in hledger-ui after update to 1.10.1 Jul 15, 2018

@dstrelnikov

This comment has been minimized.

dstrelnikov commented Jul 15, 2018

I confirm the bag also on version 1.10.

@dstrelnikov

This comment has been minimized.

dstrelnikov commented Oct 23, 2018

Just upgraded to hledger-ui 1.11, the same behavior.

@simonmichael

This comment has been minimized.

Owner

simonmichael commented Oct 23, 2018

Fixed in master. Thanks for the report!

@dstrelnikov

This comment has been minimized.

dstrelnikov commented Oct 23, 2018

Fixed in master. Thanks for the report!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment