Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
transaction modifiers miss inferred amounts in transaction #893
Running with a stack build of up-to-date master.
Transaction modifiers seem to interact oddly with inferred amounts. The following works as expected:
But the following does not:
changed the title from
transaction modifiers miss some accounts in transaction
transaction modifiers miss inferred amounts in transaction
Oct 9, 2018
I figured out the issue: it was applying the modifiers before it finalized the journal with
[EDIT: this solution doesn't work, for the reasons discussed in this post. There is a better solution in the post below.]
Now this works:
BUT, this produces its own problem. Because the application happens after the finalization, it no longer checks to make sure they balance. So we can now have:
So it seems like the best option would be to run finalize twice: before and after modification. This makes the most intuitive sense since the journal should work both with and without
I could also try to split out infernce from finalize, but I imagine there are other checks that would end up missing, so running it twice if you have auto seems like the most direct route.
Also: when do you use doctests and when do you use easytests? I'll add tests when i make a PR but I'm not sure what you usually do.