Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix a few spaceleaks #413
This is the result of applying Neil Mitchell’s trick of limiting the stack size to hledger.
Let me break down the different changes:
Here are the benchmark results:
Memory usage doesn’t seem to be significantly impacted (although it looks like it goes slightly down with this patch).
Thanks. Here's what I get:
Or using the benchmark suite:
Or with criterion:
If anything, it seems slower, as far as I can measure ?
Some of that new code sounds nice to have, but we should probably see a real benefit before giving up the readability and familiarity and low maintenance of standard library functions. I think that also goes for INLINABLE, which we discussed on another PR.
I disagree with that part. Adding
The differences in the benchmarks look too small to be significant. I would expect that if you run it a few times you’ll see differences in that range in both directions.
Measuring space usage. A small improvement ?: