Added .btn-default to unify buttons across browsers #418

Merged
merged 1 commit into from Oct 11, 2016

Projects

None yet

2 participants

@theSuess
Contributor

By overriding the default brower-styles using the class btn-default, the buttons on hldeger-web are now rendered the same on all browsers. It also gives the interface a cleaner look
before_after

@theSuess theSuess Added .btn-default to unify buttons across browsers
c24c18e
@simonmichael

Thanks! Consistency sounds nice.

On the other hand, it's now less obviously a clickable button. What's the normal fix for that ? What is the normal best practice for using/not using btn-default ?

@theSuess
Contributor

The default bootstrap distribution offers seven kind of buttons.
btnclasses

For this usecase, making the search button primary should probably be enough. I would leave the "?" button as is though because the first one being a button should be enough of a hint to suggest that it is clickable as well

@simonmichael
Owner
simonmichael commented Oct 11, 2016 edited

My habit is to stick with minimal, low-colour styling (but enough to indicate buttons, etc.) until a better UI theme arrives. Won't styling just this button differently from the overall UI seem odd ?

But I'll probably merge whatever you do anyway, to refresh the eyes.

@simonmichael simonmichael merged commit 36d2998 into simonmichael:master Oct 11, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@theSuess
Contributor

You're right, for fancy buttons the ui needs to be overhauled.
I'll probably tackle issue #340 next so we'll see how everything plays togeher. Thanks for merging!

@simonmichael
Owner

Thanks @theSuess!

@mstksg mstksg added a commit to mstksg/hledger that referenced this pull request Feb 3, 2017
@theSuess @mstksg theSuess + mstksg Added .btn-default to unify buttons across browsers (#418) 03fab96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment