Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
"balance" parser for csv reader #537
Nice! I ask myself how much benefit this brings, but I currently put paypal's balance in a transaction comment for troubleshooting/informational purposes, so I guess why not check it as well, given that the performance impact seems quite small.
But as you mentioned in IRC, ordering issues might be a problem. We might get multiple same-day transactions, and we can't rely on the ordering of same-day CSV records. We might also see multiple same-account postings in a transaction (if not now, then in future). How easy/efficient would it be to omit the assertions in just these cases ?
I've played a bit more with this patch, and I am liking it more and more.
It is highly unlikely that within singe CSV file that has balance there would be out-of-order transactions. In only encounetered issues with multiple current accounts in a single bank, where each account have its own CSV file and transfers between account are therefore present in both.
Previously i've been dropping one transfer transaction out of two, pretty much at random, and this is what played havoc with balance assertions. Once I kept both of them, writing a rule so that one transfer is getting imported as "account A -> special account for transfers" and second transfer is "special account for transfers -> account B", my balances got in order and every assertion checked out.
I no longer believe that my reordering idea is necessary at all, and you are right - it is unnecessart complicated.
Apr 14, 2017
1 check passed
Some issues noticed recently:
Yes, my bad. Made #539 to fix this…
On Mon, Apr 17, 2017 at 4:18 PM, Simon Michael ***@***.***> wrote: PS so the "If you assign empty string to it, no assertion will be generated" case mentioned in the docs, doesn't seem to be working here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#537 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHNKlYVbQSz_Y7BcL18hI7FlkhXvVfkks5rw4KzgaJpZM4M9Tlx> .
-- Dmitry Astapov