New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Fixed Assets from Cashflow Report #584

Merged
merged 1 commit into from Aug 27, 2017

Conversation

Projects
None yet
2 participants
@cwarden
Collaborator

cwarden commented Jul 13, 2017

Add "fixed" to the regex used to exclude asset accounts from cashflow
reports. Assumes accounts are set up something like:

assets:fixed assets:equipment
assets:fixed assets:vehicles
assets:fixed assets:buildings
Exclude Fixed Assets from Cashflow Report
Add "fixed" to the regex used to exclude asset accounts from cashflow
reports.  Assumes accounts are set up something like:
assets:fixed assets:equipment
assets:fixed assets:vehicles
assets:fixed assets:buildings
@simonmichael

I didn't understand the repeated accounts in description, assuming just a typo.

We want to remove hard-coded anglo-centric patterns, but this seems fine until #523 arrives.

Related: do any of the syntax proposals for #523 allow excluding certain subaccounts, like we do here ? I think they don't.

@@ -293,9 +293,9 @@ journalEquityAccountQuery _ = Acct "^equity(:|$)"
-- | A query for Cash (-equivalent) accounts in this journal (ie,
-- accounts which appear on the cashflow statement.) This is currently
-- hard-coded to be all the Asset accounts except for those containing the
-- case-insensitive regex @(receivable|A/R)@.
-- case-insensitive regex @(receivable|A/R|fixed)@.

This comment has been minimized.

@simonmichael

simonmichael Jul 15, 2017

Owner

Perhaps :fixed would be better ? So as not to match assets:unfixed, assets:non-fixed etc.

@simonmichael

simonmichael Jul 15, 2017

Owner

Perhaps :fixed would be better ? So as not to match assets:unfixed, assets:non-fixed etc.

@simonmichael simonmichael merged commit deaf9cf into simonmichael:master Aug 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

simonmichael added a commit that referenced this pull request Aug 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment