Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make transaction modifiers work correctly with inferred amounts #900
This solves #893 by having
Also, there's a chance --auto could be always-on in future. Hopefully this doesn't have much performance impact, but we should probably think about/test that a little more.
I added a commit (8cbead6) which only does the double run if
(Informal tests showed a slight performance hit when using
Yep good idea, it looks much clearer.
ErroringJournalParser is a variant of JournalParser that can abort parsing by throwing an exception. It's our most general and featureful kind of journal parser. Some months ago we removed it thinking it was unneeded, and it has recently been re-added.
Oct 12, 2018
1 check passed
It's true that one can replace
A practical reason would be getting rid of duplicated code and one more type folks don't have to think about. (We could also factor out the common code). I think there's no harm in standardising and using the more powerful type for the time parsers even though they don't make use of it yet.