Remove all hardcoded (serial) console service files #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are incorrectly created by buildroot and cause either a warning or real issues where the serial console won't work depending on what BR2_TARGET_GENERIC_GETTY_PORT is set to. To ensure this doesn't happen we simply delete all the files (which buildroot has created) in /etc/systemd/system/getty.target.wants
|
Checked the image built by Circle and it works correctly now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are incorrectly created by buildroot and cause either a warning or real issues where the serial console won't work
depending on what BR2_TARGET_GENERIC_GETTY_PORT is set to.
To ensure this doesn't happen we simply delete all the files (which buildroot has created) in /etc/systemd/system/getty.target.wants
This behavior has been incorrect in buildroot for a while but with the introduction of buildroot/buildroot@940e7de it broke our serial console.
The default should be to not create any of these when systemd is used and let the user add additional ones if he/she wants to.