Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json / CSV links are broken in Datasette 0.50 #1010

Closed
simonw opened this issue Oct 10, 2020 · 3 comments
Closed

json / CSV links are broken in Datasette 0.50 #1010

simonw opened this issue Oct 10, 2020 · 3 comments
Labels

Comments

@simonw
Copy link
Owner

simonw commented Oct 10, 2020

e.g. on https://latest.datasette.io/fixtures/sortable

That export link block is broken. The HTML is:

<p class="export-links">
  This data as <a href="//fixtures/sortable.json">json</a>,
  <a href="//fixtures/sortable.csv?_size=max">CSV</a> (<a href="#export">advanced</a>)
</p>
@simonw simonw added the bug label Oct 10, 2020
@simonw
Copy link
Owner Author

simonw commented Oct 10, 2020

This commit broke it: 8f97b9b#diff-ed4bb3a97b7efa4d45be6a6ea6f4636cL114-R165

Banners_and_Alerts_and_datasette_client_internal_requests_mechanism_·_simonw_datasette_8f97b9b

@simonw simonw closed this as completed in c13d184 Oct 10, 2020
@simonw
Copy link
Owner Author

simonw commented Oct 10, 2020

Since this is an urgent fix that needs to go out I've marked the base_url tests as xfail. I need to solve those separately, see #900 and various other bug reports.

@simonw
Copy link
Owner Author

simonw commented Oct 10, 2020

@simonw simonw reopened this Oct 10, 2020
simonw added a commit that referenced this issue Oct 10, 2020
@simonw simonw closed this as completed Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant