Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "delete" icon next to filters (in addition to "remove filter") #1016

Closed
simonw opened this issue Oct 11, 2020 · 3 comments
Closed

Add a "delete" icon next to filters (in addition to "remove filter") #1016

simonw opened this issue Oct 11, 2020 · 3 comments

Comments

@simonw
Copy link
Owner

simonw commented Oct 11, 2020

The "remove filter" option in the select box is not very discoverable.

evernote__notes__85_rows_where_where_source-url_is_not_blank_sorted_by_id

It would be good to have an additional remove icon, pointed to by the pink arrow, which removes a specific selected filter.

@simonw simonw added the design label Oct 11, 2020
@simonw
Copy link
Owner Author

simonw commented Oct 11, 2020

For consistency can reuse the icon used on selected facets:

evernote__notes__8_rows_where_where_application-data____ACD4B543-4663-40B2-BAF5-666FA54D4204__and_source-url_is_not_blank_sorted_by_id

@simonw
Copy link
Owner Author

simonw commented Oct 12, 2020

Should this do the equivalent of clicking Apply for you? I don't think so - that wouldn't fit with how the rest of that block of controls works.

But if it makes the row vanish it may not be clear to the user that they still need to click Apply.

Easiest thing would be for it to select the "remove filter" column and blank out the boxes. I will try that first.

The code can go in table.js.

@simonw simonw closed this as completed Oct 12, 2020
simonw added a commit that referenced this issue Oct 20, 2020
@simonw simonw added this to the 0.51 milestone Oct 23, 2020
simonw added a commit that referenced this issue Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant