Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table/database action menu cut off if too short #1084

Closed
simonw opened this issue Nov 6, 2020 · 4 comments
Closed

Table/database action menu cut off if too short #1084

simonw opened this issue Nov 6, 2020 · 4 comments
Labels
bug css
Milestone
Datasette 0.52

Comments

@simonw
Copy link
Owner

simonw commented Nov 6, 2020

3CC0C181-959E-4B20-BE39-806ED93E833E
@simonw simonw added this to the Datasette 0.52 milestone Nov 13, 2020
@simonw simonw mentioned this issue Nov 21, 2020
Closed
@simonw
Copy link
Owner Author

simonw commented Nov 21, 2020

Another example of this bug: https://datasette-graphql-demo.datasette.io/github/users

github__users__4_823_rows_and_Comparing_1_1___main_·_simonw_datasette-graphql

simonw added a commit that referenced this issue Nov 21, 2020
@simonw
Fix off-screen action menu bug, refs #1084
4bac9f1
@simonw
Copy link
Owner Author

simonw commented Nov 21, 2020

Fixed by positioning the menu relative to the <div class="page-header"> element rather than the cog icon:

data

@simonw
Copy link
Owner Author

simonw commented Nov 21, 2020

I got to use CSS calc() for this:

datasette/datasette/static/app.css

Lines 367 to 371 in 4bac9f1

.actions-menu-links .dropdown-menu {
position: absolute;
top: calc(100% + 10px);
left: -10px;
}

simonw added a commit to simonw/datasette-graphql that referenced this issue Nov 21, 2020
@simonw
Deploy using latest Datasette
81b5f3d 
To help test simonw/datasette#1084
@simonw
Copy link
Owner Author

simonw commented Nov 21, 2020

https://datasette-graphql-demo.datasette.io/github/users now demonstrates the fix.

@simonw simonw closed this as completed Nov 21, 2020
simonw added a commit that referenced this issue Nov 28, 2020
@simonw
Release 0.52
a8e66f9 
Refs #992, #1103, #1104, #1107, #1077, #1110, #1089, #1086, #1088, #1084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug css
Projects
None yet
Milestone
Datasette 0.52
Development

No branches or pull requests
1 participant
@simonw