Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreign keys with blank titles result in non-clickable links #1086

Closed
simonw opened this issue Nov 11, 2020 · 3 comments
Closed

Foreign keys with blank titles result in non-clickable links #1086

simonw opened this issue Nov 11, 2020 · 3 comments
Labels
bug
Milestone
Datasette 0.52

Comments

@simonw
Copy link
Owner

simonw commented Nov 11, 2020

index__core_snapshot_tags__3_rows_and_swarm__select_venues_name__checkins_id__createdAt__type__timeZoneOffset__editableUntil___like___isMayor__source__venue__createdBy__event__sticker__created__comments_count__entities__shout__checkins_priv

The HTML looks like this:

<td class="col-tag_id type-int"><a href="/index/core_tag/1"></a>&nbsp;<em>1</em></td>
@simonw simonw added the bug label Nov 11, 2020
@simonw
Copy link
Owner Author

simonw commented Nov 11, 2020

Maybe use a grey hyphen here?

@simonw
Copy link
Owner Author

simonw commented Nov 11, 2020

I'm just going to use a regular coloured hyphen.

@simonw simonw closed this as completed in 2a981e2 Nov 11, 2020
@simonw
Copy link
Owner Author

simonw commented Nov 11, 2020

Demo: https://latest.datasette.io/fixtures/foreign_key_references?_facet=foreign_key_with_blank_label

fixtures__foreign_key_references__2_rows

@simonw simonw added this to the Datasette 0.52 milestone Nov 28, 2020
simonw added a commit that referenced this issue Nov 28, 2020
@simonw
Release 0.52
a8e66f9 
Refs #992, #1103, #1104, #1107, #1077, #1110, #1089, #1086, #1088, #1084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Datasette 0.52
Development

No branches or pull requests
1 participant
@simonw