Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to increase size of the SQL editor window #1236

Closed
simonw opened this issue Feb 19, 2021 · 9 comments
Closed

Ability to increase size of the SQL editor window #1236

simonw opened this issue Feb 19, 2021 · 9 comments

Comments

@simonw
Copy link
Owner

simonw commented Feb 19, 2021

No description provided.

@simonw
Copy link
Owner Author

simonw commented Feb 19, 2021

I can use https://github.com/Sphinxxxx/cm-resize for this

@simonw
Copy link
Owner Author

simonw commented Feb 19, 2021

I only want it to resize up and down, not left to right - so I'm not keen on the default resize handle:

cm-resize_demo

https://rawgit.com/Sphinxxxx/cm-resize/master/demo/index.html

@simonw
Copy link
Owner Author

simonw commented Feb 19, 2021

I'm going to use a variant of the Datasette menu icon. Here it is in #ccc with an ARIA label:

<svg aria-labelledby="cm-drag-to-resize" role="img" fill="#ccc" stroke="#ccc" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" width="16" height="16">
  <title id="cm-drag-to-resize">Drag to resize</title>
  <path fill-rule="evenodd" d="M1 2.75A.75.75 0 011.75 2h12.5a.75.75 0 110 1.5H1.75A.75.75 0 011 2.75zm0 5A.75.75 0 011.75 7h12.5a.75.75 0 110 1.5H1.75A.75.75 0 011 7.75zM1.75 12a.75.75 0 100 1.5h12.5a.75.75 0 100-1.5H1.75z"></path>
</svg>

@simonw
Copy link
Owner Author

simonw commented Feb 19, 2021

Encoded using https://meyerweb.com/eric/tools/dencoder/

%3Csvg%20aria-labelledby%3D%22cm-drag-to-resize%22%20role%3D%22img%22%20fill%3D%22%23ccc%22%20stroke%3D%22%23ccc%22%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%2016%2016%22%20width%3D%2216%22%20height%3D%2216%22%3E%0A%20%20%3Ctitle%20id%3D%22cm-drag-to-resize%22%3EDrag%20to%20resize%3C%2Ftitle%3E%0A%20%20%3Cpath%20fill-rule%3D%22evenodd%22%20d%3D%22M1%202.75A.75.75%200%20011.75%202h12.5a.75.75%200%20110%201.5H1.75A.75.75%200%20011%202.75zm0%205A.75.75%200%20011.75%207h12.5a.75.75%200%20110%201.5H1.75A.75.75%200%20011%207.75zM1.75%2012a.75.75%200%20100%201.5h12.5a.75.75%200%20100-1.5H1.75z%22%3E%3C%2Fpath%3E%0A%3C%2Fsvg%3E

@simonw
Copy link
Owner Author

simonw commented Feb 19, 2021

resize-demo

@simonw
Copy link
Owner Author

simonw commented Feb 19, 2021

Now live on https://latest.datasette.io/_memory

@simonw
Copy link
Owner Author

simonw commented Feb 19, 2021

Need to test this on mobile.

@simonw
Copy link
Owner Author

simonw commented Feb 22, 2021

It's good on mobile - iOS at least. Going to close this open new issues if anyone reports bugs.

@simonw simonw closed this as completed Feb 22, 2021
simonw added a commit that referenced this issue Mar 29, 2021
@mroswell
Copy link
Sponsor Contributor

That corner handle looks like a hamburger menu to me. Note that the default resize handle is not limited to two-way resize: http://jsfiddle.net/LLrh7Lte/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants