Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If view is filtered, search should apply within those filtered rows #133

Closed
simonw opened this issue Nov 19, 2017 · 3 comments
Closed

If view is filtered, search should apply within those filtered rows #133

simonw opened this issue Nov 19, 2017 · 3 comments

Comments

@simonw
Copy link
Owner

simonw commented Nov 19, 2017

Eg on https://sf-trees.now.sh/sf-trees-ebc2ad9/Street_Tree_List?qSpecies=1

@simonw simonw added this to the SQLite extensions, advanced JSON and FTS search edition milestone Nov 19, 2017
@simonw
Copy link
Owner Author

simonw commented Nov 20, 2017

This may be tackled by the filters work happening in #86

@simonw simonw modified the milestones: SQLite extensions, advanced JSON and FTS search edition, Foreign key edition Nov 23, 2017
@simonw
Copy link
Owner Author

simonw commented Nov 23, 2017

Easiest way to do this will be to move it into the same <form> as the filters.

Would be nice to detect ?_search=<blank> and redirect to URL without the _search parameter, just for aesthetics.

@simonw simonw closed this as completed in a802cbe Nov 24, 2017
@simonw
Copy link
Owner Author

simonw commented Nov 24, 2017

sf-trees__street_tree_list__1_row_where_search_matches__ocean___qcareassistant____1__qcareassistant_is_not_blank_and_qlegalstatus___1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant