"More" link for facets that shows _facet_size=max results

[simonw]

Original title: "More" link for facets that shows the full set of results

The simplest way to do this will be to have it link to a generated SQL query.

Originally posted by @simonw in #1332 (comment)

[simonw]

The tricky thing about this is that ideally I'd like this to link to a paginated set of results - but arbitrary SQL queries do not yet support pagination, see #856.

[simonw]

Here's a much easier way to implement this: implement ?_facet_size=max (sets it to max_returned_rows, default 1000) and then link to that from the ellipsis.

[simonw]

In order to cleanly implement this I need to expose the path_with_replaced_args utility function to Datasette's template engine. This is the first time this will become an exposed (and hence should-by-documented) API and I don't like its shape much.

[simonw]

Turns out path_with_replaced_args() is already exposed to the table.html template context:

datasette/datasette/views/table.py

Lines 897 to 900 in f1c29fd

	"is_sortable": any(c["sortable"] for c in display_columns),
	"path_with_replaced_args": path_with_replaced_args,
	"path_with_removed_args": path_with_removed_args,
	"append_querystring": append_querystring,

[simonw]

Demo: https://latest.datasette.io/fixtures/facetable?_facet_size=2&_facet=state&_facet=city_id

[simonw]

More exciting demo: https://fivethirtyeight.datasettes.com/fivethirtyeight/antiquities-act%2Factions_under_antiquities_act?_facet=states&_facet=current_agency&_facet=pres_or_congress

[simonw]

Here's a demo showing that once you get above 1,000 results you still get the "..." but it no longer links to anything: https://fivethirtyeight.datasettes.com/fivethirtyeight/births%2FUS_births_2000-2014_SSA?_facet=births&_facet_size=max