Trace should show queries on the write connection too

[simonw]

Here's why - trace only applies to read, not write SQL operations:

datasette/datasette/database.py

Lines 209 to 211 in 7c8f8aa

	with trace("sql", database=self.name, sql=sql.strip(), params=params):
	results = await self.execute_fn(sql_operation_in_thread)
	return results

Originally posted by @simonw in #1555 (comment)

[simonw]

Prototype:

diff --git a/datasette/database.py b/datasette/database.py
index 0a0c104..468e936 100644
--- a/datasette/database.py
+++ b/datasette/database.py
@@ -99,7 +99,9 @@ class Database:
             with conn:
                 return conn.execute(sql, params or [])
 
-        return await self.execute_write_fn(_inner, block=block)
+        with trace("sql", database=self.name, sql=sql.strip(), params=params):
+            results = await self.execute_write_fn(_inner, block=block)
+        return results
 
     async def execute_write_fn(self, fn, block=False):
         task_id = uuid.uuid5(uuid.NAMESPACE_DNS, "datasette.io")

[simonw]

Now running at https://latest-with-plugins.datasette.io/github/commits?_trace=1