500 from missing table name

[earthboundkid]

datasette/datasette/app.py

Lines 517 to 519 in 56623e4

	table_definition = list(await self.execute(name, 'select sql from sqlite_master where name = :n and type="table"', {
	'n': table,
	}))[0][0]

throws an error if it gets an empty list back. Simplest solution is to write a helper func that just says

result = list(await self.execute(name, sql, params)
if result:
    return result[0][0]

and use it anywhere [0][0] is now.

[simonw]

Do you have steps to reproduce here - ideally a small example SQLite database that exhibits the error?

[earthboundkid]

Visit https://salaries.news.baltimoresun.com/salaries/bad-table.

[simonw]

Yuck, nasty - OK I get it, this happens with ANY non-existent table name. Let's fix that - these should clearly return an HTTP 404.

[earthboundkid]

Reopening this because it still raises 500 for incorrect table capitalization.

Example:

• https://salaries.news.baltimoresun.com/salaries/2018+Maryland+state+salaries/1 200 OK
• https://salaries.news.baltimoresun.com/salaries/bad-table/1 400
• https://salaries.news.baltimoresun.com/salaries/2018+maryland+state+salaries/1 500 Internal Error (note lowercase 'm')

I think because the table name exists but is not in its canonical form, it triggers a dict lookup error.