Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename table_rows and filtered_table_rows to have _count suffix #194

Closed
simonw opened this issue Apr 8, 2018 · 2 comments
Closed

Rename table_rows and filtered_table_rows to have _count suffix #194

simonw opened this issue Apr 8, 2018 · 2 comments

Comments

@simonw
Copy link
Owner

simonw commented Apr 8, 2018 •
edited
Loading

These fields represent counts of items:

"table_rows": 131,
"filtered_table_rows": 8,

But the names make it sound like they might be arrays full of rows. Adding a _count suffix would make this more clear:

"table_rows_count": 131,
"filtered_table_rows_count": 8,
@simonw simonw added this to the Advanced JSON edition milestone Apr 8, 2018
@simonw simonw mentioned this issue Apr 8, 2018
Closed
7 tasks
@simonw
Copy link
Owner Author

simonw commented Apr 8, 2018 •
edited
Loading

table_rows_count is always the total number of rows in the table.

@simonw
Copy link
Owner Author

simonw commented Apr 8, 2018

Maybe table_rows_filtered_count would be more aesthetically pleasing than filtered_table_rows_count.

@simonw simonw closed this as completed in a290f28 Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw