Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTS table detection should be part of .inspect() #240

simonw opened this issue Apr 26, 2018 · 0 comments

FTS table detection should be part of .inspect() #240

simonw opened this issue Apr 26, 2018 · 0 comments


Copy link

simonw commented Apr 26, 2018

The code that detects if specific tables have a corresponding FTS column is currently called from TableView - it should instead be handled as part of .inspect(). This will make it easier to build other features that need to behave differently depending on whether a table can be searched, e.g. an autocomplete widget for selecting filters from foreign key tables.

Current code:


Lines 728 to 733 in f188cea

# _search support:
fts_table = None
fts_sql = detect_fts_sql(table)
fts_rows = list(await self.execute(name, fts_sql))
if fts_rows:
fts_table = fts_rows[0][0]

@simonw simonw added the small label Apr 26, 2018
@simonw simonw closed this as completed in aa95438 Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

1 participant