Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up app.py into separate view modules #256

Closed
simonw opened this issue May 12, 2018 · 1 comment
Closed

Break up app.py into separate view modules #256

simonw opened this issue May 12, 2018 · 1 comment

Comments

@simonw
Copy link
Owner

simonw commented May 12, 2018

views/table.py and views/database.py and views/utils.py as a starting point.

Likewise, create tests/test_views_table.py and tests/test_views_database.py - these will contain both HTML and API test for those views.
simonw added a commit that referenced this issue May 13, 2018
@simonw
Refactored views into new views/ modules, refs #256
f4f88ce
@simonw simonw mentioned this issue May 13, 2018
Merged
simonw added a commit that referenced this issue May 14, 2018
@simonw
Refactored views into new views/ modules, refs #256
1f69269
@simonw
Copy link
Owner Author

simonw commented May 14, 2018

I just landed pull request #257 - I haven't refactored the tests, I may do that later if it looks worthwhile.

@simonw simonw closed this as completed May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw