New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis should push tagged images to Docker Hub for each release #329

Open
simonw opened this Issue Jun 28, 2018 · 6 comments

Comments

Projects
None yet
2 participants

@simonw simonw referenced this issue Jun 28, 2018

Closed

Ship a Docker image of the whole thing #57

1 of 2 tasks complete

@simonw simonw added this to the Next release milestone Jul 10, 2018

@simonw simonw added the travis-ci label Jul 13, 2018

@simonw

This comment has been minimized.

Show comment
Hide comment
@simonw

simonw Jul 24, 2018

Owner

Hopefully this will do the trick: 2bdab66

Owner

simonw commented Jul 24, 2018

Hopefully this will do the trick: 2bdab66

@simonw

This comment has been minimized.

Show comment
Hide comment
@simonw

simonw Jul 24, 2018

Owner

It almost worked... but I had to fix the docker login command: 3a46d5e

Hopefully the next release will be published correctly.

Owner

simonw commented Jul 24, 2018

It almost worked... but I had to fix the docker login command: 3a46d5e

Hopefully the next release will be published correctly.

@simonw simonw removed this from the Next release milestone Jul 24, 2018

@jaywgraves

This comment has been minimized.

Show comment
Hide comment
@jaywgraves

jaywgraves Sep 19, 2018

Contributor

I'm using the docker image (0.23.2) and notice some differences/bugs between the docs and the published version with canned queries. (submitted a tiny doc fix also)

I was able to build the docker container locally using master and I'm using that for now.
Would it be possible to manually push 0.24 to DockerHub until the TravisCI stuff is fixed?

I would like to run this in our Kubernetes cluster but don't want to publish a version in our internal registry if I don't have to.
Thanks!

Contributor

jaywgraves commented Sep 19, 2018

I'm using the docker image (0.23.2) and notice some differences/bugs between the docs and the published version with canned queries. (submitted a tiny doc fix also)

I was able to build the docker container locally using master and I'm using that for now.
Would it be possible to manually push 0.24 to DockerHub until the TravisCI stuff is fixed?

I would like to run this in our Kubernetes cluster but don't want to publish a version in our internal registry if I don't have to.
Thanks!

@simonw

This comment has been minimized.

Show comment
Hide comment
@simonw

simonw Sep 19, 2018

Owner

The new 0.25 release has been successfully pushed to Docker Hub! https://hub.docker.com/r/datasetteproject/datasette/tags/

One catch: it looks like it didn't update the "latest" tag to point at it. Looking into that now.

Owner

simonw commented Sep 19, 2018

The new 0.25 release has been successfully pushed to Docker Hub! https://hub.docker.com/r/datasetteproject/datasette/tags/

One catch: it looks like it didn't update the "latest" tag to point at it. Looking into that now.

@simonw

This comment has been minimized.

Show comment
Hide comment
@simonw

simonw Sep 19, 2018

Owner

I fixed that by running the following on my laptop:

$ docker pull datasetteproject/datasette:0.25
$ docker tag datasetteproject/datasette:0.25 datasetteproject/datasette:latest
$ docker push datasetteproject/datasette

The latest tag now points to the most recent release.

Owner

simonw commented Sep 19, 2018

I fixed that by running the following on my laptop:

$ docker pull datasetteproject/datasette:0.25
$ docker tag datasetteproject/datasette:0.25 datasetteproject/datasette:latest
$ docker push datasetteproject/datasette

The latest tag now points to the most recent release.

simonw added a commit that referenced this issue Sep 19, 2018

@jaywgraves

This comment has been minimized.

Show comment
Hide comment
@jaywgraves

jaywgraves Sep 19, 2018

Contributor

That works for me. Was able to pull the public image and no errors on my canned query. (although a small rendering bug. I'll create an issue and if I have time today, a PR to fix this turned out to be my error.)
Thanks for the quick response!

Contributor

jaywgraves commented Sep 19, 2018

That works for me. Was able to pull the public image and no errors on my canned query. (although a small rendering bug. I'll create an issue and if I have time today, a PR to fix this turned out to be my error.)
Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment