Datasette on Zeit Now returns http URLs for facet and next links

[simonw]

e.g. on https://fivethirtyeight.datasettes.com/fivethirtyeight-ac35616/nba-elo%2Fnbaallelo.json?_facet=lg_id&_size=0

{
  "facet_results": {
    "lg_id": {
      "name": "lg_id",
      "results": [
        {
          "value": "NBA",
          "label": "NBA",
          "count": 118016,
          "toggle_url": "http://fivethirtyeight.datasettes.com/fivethirtyeight-ac35616/nba-elo%2Fnbaallelo.json?_facet=lg_id&_size=1&lg_id=NBA",
          "selected": false
        },
        {
          "value": "ABA",
          "label": "ABA",
          "count": 8298,
          "toggle_url": "http://fivethirtyeight.datasettes.com/fivethirtyeight-ac35616/nba-elo%2Fnbaallelo.json?_facet=lg_id&_size=1&lg_id=ABA",
          "selected": false
        }
      ],
      "truncated": false
    }
  },
  "suggested_facets": [
    {
      "name": "_iscopy",
      "toggle_url": "/fivethirtyeight-ac35616/nba-elo%2Fnbaallelo.json?_facet=lg_id&_size=1&_facet=_iscopy"
    }
  ],
  "next_url": "http://fivethirtyeight.datasettes.com/fivethirtyeight-ac35616/nba-elo%2Fnbaallelo.json?_facet=lg_id&_size=1&_next=1",
}

next_url and facet_results both link to http:// when they should link to https://.

Note that suggested facets doesn't include the full URL at all, which is a consistency bug.

[simonw]

A force_https_api_urls config option would work here - if set, Datasette will ignore the incoming protocol and always use https. The datasette deploy now command could then add that as an option passed to datasette serve.

This is the pattern which is producing incorrect URLs on Zeit Now, because the Sanic request.url property is not being correctly set.

datasette/datasette/views/table.py

Lines 653 to 655 in 6e37f09

	next_url = urllib.parse.urljoin(
	request.url, path_with_replaced_args(request, added_args)
	)

Suggested help text:

Always use https:// for URLs output as part of Datasette API responses

[simonw]

I'll add a absolute_url(request, path) method on the base view class which knows to check the new config option.

[simonw]

I still need to modify datasette publish now to set this config option on the instances that it deploys.

[simonw]

Demo: https://700d83d.datasette.io/fixtures-dcc1dbf/facetable.json?_facet=state&_size=5&_labels=on