Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra_options not passed to heroku publisher #334

Closed
kamicut opened this issue Jul 6, 2018 · 2 comments
Closed

extra_options not passed to heroku publisher #334

kamicut opened this issue Jul 6, 2018 · 2 comments

Comments

@kamicut
Copy link

kamicut commented Jul 6, 2018

I might be wrong but I was not able to publish to heroku with --extra-options, I think extra_options is not being used in this function here.

Any help appreciated!

@simonw
Copy link
Owner

simonw commented Jul 9, 2018

Yup that's definitely a bug.

@simonw
Copy link
Owner

simonw commented Jul 10, 2018

Tested with datasette publish heroku fixtures.db --extra-options="--config sql_time_limit_ms:4000"

https://blooming-anchorage-31561.herokuapp.com/-/config

@simonw simonw closed this as completed in 17863d1 Jul 10, 2018
@simonw simonw added this to the Next release milestone Jul 10, 2018
@simonw simonw removed this from the Next release milestone Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants