Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ?_fts_table=x and ?_fts_pk=y available as URL parameters on table view #428

Closed
simonw opened this issue Apr 12, 2019 · 2 comments
Closed

Comments

@simonw
Copy link
Owner

@simonw simonw commented Apr 12, 2019

These can currently only be set using metadata.json: https://datasette.readthedocs.io/en/0.27/full_text_search.html#configuring-full-text-search-for-a-table-or-view

There's no reason not to support these as URL parameters as well. That way it would be easy to use FTS search against a view without having to use metadata.json.

@simonw
Copy link
Owner Author

@simonw simonw commented Apr 12, 2019

It looks like I accidentally broke the fts_table metadata mechanism here: 3a208a4#diff-5e0ffd62fced7d46339b9b2cd167c2f9L297

I'll fix that as part of this work.

@simonw simonw closed this in db74cf0 Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant