Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins are loaded when running pytest #438

Closed
russss opened this issue Apr 29, 2019 · 2 comments
Closed

Plugins are loaded when running pytest #438

russss opened this issue Apr 29, 2019 · 2 comments

Comments

@russss
Copy link
Contributor

@russss russss commented Apr 29, 2019

If I have a datasette plugin installed on my system, its hooks are called when running the main datasette tests. This is probably undesirable, especially with the inspect hook in #437, as the plugin may rely on inspected state that the tests don't know about.

@simonw
Copy link
Owner

@simonw simonw commented May 1, 2019

Yeah this is a good call. Having pytest set some kind of flag (maybe an environment variable?) that disables auto-plugin discovery is a very reasonable fix here.

@simonw simonw closed this in f553a67 May 2, 2019
simonw added a commit that referenced this issue May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants