Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish commands should use new -i option #469

simonw opened this issue May 16, 2019 · 1 comment

publish commands should use new -i option #469

simonw opened this issue May 16, 2019 · 1 comment


Copy link

simonw commented May 16, 2019

I can make this change only after releasing 0.28 - if I make the change earlier than that publish heroku etc will break because they will install the latest release of Datasette which will not understand the -i option.

This is a one-line fix: replace this:

quoted_files = " ".join(map(shlex.quote, file_names))

With this: (need to do it for other publishers too though)

quoted_files = " ".join(
    ["-i {}".format(shlex.quote(file_name)) for file_name in file_names]
Copy link
Owner Author

simonw commented May 19, 2019

I manually tested this against heroku, cloud run and nowv1 and all three worked as expected - in particular they all offered working "download this database" links.

@simonw simonw closed this as completed in e513a80 May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

1 participant