Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination breaks when combined with expanded foreign keys #489

Closed
simonw opened this issue May 27, 2019 · 1 comment
Closed

Pagination breaks when combined with expanded foreign keys #489

simonw opened this issue May 27, 2019 · 1 comment
Labels
bug small

Comments

@simonw
Copy link
Owner

simonw commented May 27, 2019 •
edited
Loading

Consider https://edb3662.datasette.io/fixtures/roadside_attraction_characteristics?_sort=attraction_id&_size=2

The "Next page" link goes here, which returns 0 rows:

https://edb3662.datasette.io/fixtures/roadside_attraction_characteristics?_size=2&_next=%257B%2527value%2527%253A%2B2%252C%2B%2527label%2527%253A%2B%2527Winchester%2BMystery%2BHouse%2527%257D%2C2&_sort=attraction_id

That's because if you double-url-decode that _next link you get this:

_next={'value': 2, 'label': 'Winchester Mystery House'},2

It should be _next=2,2
@simonw simonw closed this as completed in 9c58d04 May 28, 2019
@simonw
Copy link
Owner Author

simonw commented May 28, 2019

Fixed: https://latest.datasette.io/fixtures/roadside_attraction_characteristics?_sort=attraction_id&_size=2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw