Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asgi_wrapper plugin hook #520

Closed
simonw opened this issue Jun 23, 2019 · 3 comments

Comments

Projects
None yet
1 participant
@simonw
Copy link
Owner

commented Jun 23, 2019

After #272 we can finally add this hook. It will allow plugins to wrap their own ASGI middleware around Datasette. Potential use-cases include:

  • adding authentication
  • custom CORS headers (see #454)
  • maybe gzip support?
  • possibly defining entirely new routes, though that may be better handled by a separate hook
@simonw

This comment has been minimized.

Copy link
Owner Author

commented Jun 23, 2019

These plugins will need access to configuration and the ability to execute SQL - which means we need to make the datasette instance available to them.

@simonw simonw pinned this issue Jun 24, 2019

@simonw

This comment has been minimized.

Copy link
Owner Author

commented Jun 24, 2019

#272 is closed now! This hook is next on the priority list.

@simonw simonw self-assigned this Jun 24, 2019

@simonw simonw changed the title prepare_asgi plugin hook asgi_wrapper plugin hook Jul 3, 2019

simonw added a commit that referenced this issue Jul 3, 2019

@simonw simonw closed this in 4d2fdaf Jul 3, 2019

@simonw simonw unpinned this issue Jul 3, 2019

@simonw

This comment has been minimized.

Copy link
Owner Author

commented Jul 3, 2019

simonw added a commit that referenced this issue Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.