Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink how metadata is generated and stored #60

Closed
simonw opened this issue Nov 11, 2017 · 1 comment
Closed

Rethink how metadata is generated and stored #60

simonw opened this issue Nov 11, 2017 · 1 comment

Comments

@simonw
Copy link
Owner

simonw commented Nov 11, 2017

I broke the existing mechanism in 407795b In order to get unit tests for the sanic app working.

I think i should ditch the build-metadata.json cache file entirely and calculate the SHA hashes on startup.

Not sure what to do about the table row counts.

@simonw simonw added the medium label Nov 11, 2017
@simonw simonw added this to the Ship v1 milestone Nov 11, 2017
@simonw
Copy link
Owner Author

simonw commented Nov 11, 2017

I’m going to solve this by making it an optional argument you can pass to the serve command. Then the Dockerfile can still build and use it but it won’t interfere with tests or dev.

If argument is not passed, we will calculate hashes on startup and calculate table row counts on demand.

@simonw simonw closed this as completed in 40a563e Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant