Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom queries with 0 results should say "0 results" #637

Closed
simonw opened this issue Nov 20, 2019 · 3 comments
Closed

Custom queries with 0 results should say "0 results" #637

simonw opened this issue Nov 20, 2019 · 3 comments
Labels
small

Comments

@simonw
Copy link
Owner

simonw commented Nov 20, 2019

Consider https://latest.datasette.io/fixtures/neighborhood_search?text=foop

fixtures__select_neighborhood__facet_cities_name__state_from_facetable_join_facet_cities_on_facetable_city_id___facet_cities_id_where_neighborhood_like_________text________order_by_neighborhood_

It's currently not obvious that the query executed and returned 0 results.
@simonw simonw added the small label Nov 20, 2019
@simonw
Copy link
Owner Author

simonw commented Nov 20, 2019

Likewise tables with 0 rows - not clear that something hasn't broken on this page: https://latest.datasette.io/fixtures/123_starts_with_digits

fixtures__123_starts_with_digits__0_rows

@simonw
Copy link
Owner Author

simonw commented Nov 23, 2019 •
edited
Loading

Design idea:

fixtures__123_starts_with_digits__0_rows

HTML:

<p style="border: 2px solid #ccc; padding: 0.5em; background-color: #eee; font-style: italic">
  0 records
</p>

@simonw simonw closed this as completed in d3e1c30 Nov 23, 2019
@simonw
Copy link
Owner Author

simonw commented Nov 23, 2019

Demo:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw