New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--port option to expose a port other than 8001 in "datasette package" #661

Closed

dvhthomas opened this issue Jan 27, 2020 · 3 comments

Labels

datasette-publish feature small

dvhthomas commented Jan 27, 2020

I see how to alter the port using datasette serve -p XXX per the docs. However, I'm packaging up to server the container on AppEngine flexible, which requires that the container is serving traffic on port 8080.

datasette/Dockerfile

Line 41 in 7950105

EXPOSE 8001

Is there a way to inject a non-default port into the Dockerfile, or should I just do something like sed to replace 8001 with 8080 after dataset package has done it's thing? Thanks for the advice.

The text was updated successfully, but these errors were encountered:

Owner

simonw commented Jan 29, 2020

Having datasette package take an optional port argument seems like a good feature to me.

simonw added datasette-publish feature small labels

simonw added a commit that referenced this issue


          -p argument for datasette package, plus tests - refs #661

07fee41

simonw closed this as completed in

67fc9c5

simonw changed the title ~~Exposing a different port that 8001 in package~~ --port option to expose a port other than 8001 in "datasette package"

Owner

simonw commented Jan 30, 2020

This has now shipped as part of Datasette 0.34: https://datasette.readthedocs.io/en/stable/changelog.html#v0-34

Author

dvhthomas commented Jan 30, 2020

Thanks for the elegant solution to the problem as stated. I'm packaging right now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment