python tests/fixtures.py command has a bug

[simonw]

This command is meant to write out fixtures.db, metadata.json and a plugins directory:

$ python tests/fixtures.py /tmp/fixtures.db /tmp/metadata.json /tmp/plugins/
Test tables written to /tmp/fixtures.db
- metadata written to /tmp/metadata.json
Traceback (most recent call last):
  File "tests/fixtures.py", line 833, in <module>
    ("my_plugin.py", PLUGIN1),
NameError: name 'PLUGIN1' is not defined

[simonw]

I broke this in #775 446e5de

Here's the now-broken code (I removed the PLUGIN1 and PLUGIN2 constants):

datasette/tests/fixtures.py

Lines 828 to 835 in 9c563d6

	if plugins_path:
	path = pathlib.Path(plugins_path)
	if not path.exists():
	path.mkdir()
	for filename, content in (
	("my_plugin.py", PLUGIN1),
	("my_plugin_2.py", PLUGIN2),
	):

[simonw]

I should replace the bodged-together argument passing with Click while I'm fixing this.

[simonw]

I don't think this is fully documented either. Current partial documentation is on https://datasette.readthedocs.io/en/stable/contributing.html

[simonw]

Switched to 0.44 milestone because I don't like shipping releases with known bugs.

[simonw]

$ python tests/fixtures.py fixtures.db fixtures-metadata.json fixtures-plugins
Test tables written to fixtures.db
- metadata written to fixtures-metadata.json
Wrote plugin: fixtures-plugins/register_output_renderer.py
Wrote plugin: fixtures-plugins/view_name.py
Wrote plugin: fixtures-plugins/my_plugin.py
Wrote plugin: fixtures-plugins/messages_output_renderer.py
Wrote plugin: fixtures-plugins/my_plugin_2.py

[simonw]

Now fully documented here: https://datasette.readthedocs.io/en/latest/contributing.html#setting-up-a-development-environment